Introduce Network Policy API #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnkoutso
force-pushed
the
dimitris/network-policy
branch
2 times, most recently
from
8e90794
to
bc6a4ae
Compare
| return (networkPolicy & NetworkPolicy.NO_STORE.index) == 0; | ||
| } | ||
|
|
||
| static boolean isOfflineOnly(int networkPolicy) { |
There was a problem hiding this comment.
These methods will need to be public, otherwise how do I know what the integer value passed to the Downloader means?
dnkoutso
force-pushed
the
dimitris/network-policy
branch
7 times, most recently
from
cf193cd
to
4269d61
Compare
dnkoutso
changed the title
|
Added some tests. Should be ready now. |
| new com.squareup.okhttp.Request.Builder().url(uri.toString()); | ||
| @Override public Response load(Uri uri, int networkPolicy) throws IOException { | ||
| CacheControl cacheControl = null; | ||
| if (networkPolicy > 0) { |
There was a problem hiding this comment.
This should be != 0 since it's a bit field
|
Rebase |
dnkoutso
force-pushed
the
dimitris/network-policy
branch
from
4269d61
to
eb60331
Compare
dnkoutso
force-pushed
the
dimitris/network-policy
branch
from
eb60331
to
eb2e973
Compare
| /** Skips checking the disk cache and forces loading through the network. */ | ||
| NO_CACHE(1 << 0), | ||
|
|
||
| /** Skips storing the result into the disk cache. |
There was a problem hiding this comment.
nit: this should be on the next line
JakeWharton
added a commit
that referenced
this pull request
Jan 5, 2015
Introduce Network Policy API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #438