Switch to read-modify-write flashing. #155
Conversation
|
|
denravonska
changed the title
denravonska
force-pushed
the
feature/program-to-address
branch
2 times, most recently
from
61b024a
to
1147466
Compare
|
Trying to figure out why the tests are failing with |
This enables programming the chip without having to erase the entire contents. Instead, JLink will erase where needed while retaining the data that's within the same sectors but outside of the specified write area. Closes square#154, square#148
Co-authored-by: Ford Peprah <hkpeprah@users.noreply.github.com>
hkpeprah
force-pushed
the
feature/program-to-address
branch
from
6bee16f
to
0256933
Compare
|
|
||
| return res | ||
| bytes_flashed = self._dll.JLINKARM_WriteMem(addr, len(data), data) |
There was a problem hiding this comment.
Debugging, it looks like data has to be a bytes vs. a list of integers, so if data is a list of integers, this will fail. I think that means we have to call bytes(data) here.
- Convert
datato bytes if not.
There was a problem hiding this comment.
Do you want to retain the signature (list of bytes) and convert to bytes when needed?
There was a problem hiding this comment.
I think keeping the signature, and convert. What I found was that [1, 2, 3, 4] failed, but bytes([1, 2, 3, 4]) succeeded, so maybe just a simple check like:
if not isinstance(data, bytes):
data = bytes(data)
There was a problem hiding this comment.
I made it a bit more strict and only convert if it's a list since that's what the function expects. Type annotations could be useful to soft enforce it.
Not tested yet :)
There was a problem hiding this comment.
Seems to be working fine here.
flash() now accepts both list[int] and bytes.
denravonska
force-pushed
the
feature/program-to-address
branch
from
191aca6
to
456ab14
Compare
|
Thanks for the submission. Should be available now in |
This enables programming the chip without having to erase the entire contents. Instead, JLink will erase where needed while retaining the data that's within the same sectors but outside of the specified write area.
I was only able to run some of the Behave tests as I don't have access to the hardware.
Closes #154, #148