Update protos to proto3 #137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 11, 2019 10:08
Ran `dep ensure`, it updated the format of the lock file and added some fields. Commiting to a have a cleaner history.
Recompiled the protos, which required updating a bunch of deps to transition from golang.org/x/net/context to context and the version of grpc supporting proto3.
|
Need to do some more testing. This'll be back later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They seemed to already be at version 3, but they hadn't been recompiled. Proto3 required an update to grpc, which changed from using
golang.org/x/net/contexttocontext, which required some pretty expansive updates.Changed from using
reflect.DeepEqualtoproto.Equalbecause of theXXX_fields in proto3 structs.