Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracing span around Allow()'s Redis call #138

Merged
merged 1 commit into from Feb 7, 2019

Conversation

spenceral
Copy link
Collaborator

This change adds observability to the hot path in quota service
deployments that use Redis as the bucket cache. It surrounds the Redis
EvalSha call with an OpenTracing span so that distributed tracing
systems can be used to see how much of Allow()'s execution time is spent
in the Redis call.

Copy link
Collaborator

@maniksurtani maniksurtani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once you sort out the dependencies.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 805

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.097%

Totals Coverage Status
Change from base Build 790: 0.0%
Covered Lines: 476
Relevant Lines: 699

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Feb 7, 2019

Pull Request Test Coverage Report for Build 805

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.097%

Totals Coverage Status
Change from base Build 790: 0.0%
Covered Lines: 476
Relevant Lines: 699

💛 - Coveralls

This change adds observability to the hot path in quota service
deployments that use Redis as the bucket cache. It surrounds the Redis
EvalSha call with an OpenTracing span so that distributed tracing
systems can be used to see how much of Allow()'s execution time is spent
in the Redis call.
@spenceral
Copy link
Collaborator Author

Rebased to bring in @szabado's Travis fixes and modules change. Thanks for those Felix!

@spenceral spenceral merged commit b368f5a into master Feb 7, 2019
@spenceral spenceral deleted the spenceral/configure-tracing branch February 7, 2019 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants