Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start running UI tests on API 30 emulators in CI. #120

Merged
merged 2 commits into from
Jan 22, 2021
Merged

Start running UI tests on API 30 emulators in CI. #120

merged 2 commits into from
Jan 22, 2021

Conversation

zach-klippenstein
Copy link
Collaborator

No description provided.

@zach-klippenstein
Copy link
Collaborator Author

Ah, the default target system image for API 30 isn't available yet (see ReactiveCircus/android-emulator-runner#106 (comment)). We need to use google_apis instead.

@zach-klippenstein zach-klippenstein changed the title Add API 30 to the UI test matrix for CI. Start running UI tests on API 30 emulators in CI. Jan 22, 2021
zach-klippenstein
zach-klippenstein commented Jan 22, 2021
View reviewed changes
radiography/build.gradle.kts
compileSdkVersion(30)
buildToolsVersion = "29.0.2"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been optional since AGP 3, and so instead of upgrading this to the latest version I just removed it.

zach-klippenstein
zach-klippenstein commented Jan 22, 2021
View reviewed changes
radiography/src/androidTest/java/radiography/test/RadiographyUiTest.kt
@@ -19,36 +18,33 @@ import java.util.concurrent.TimeUnit.SECONDS

class RadiographyUiTest {

@get:Rule
val activityRule = ActivityTestRule(TestActivity::class.java, false, false)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now deprecated, replaced by ActivityScenario and ActivityScenarioRule (we can't use the rule because each test passes a different intent).

zach-klippenstein
zach-klippenstein commented Jan 22, 2021
View reviewed changes
sample/build.gradle.kts
@@ -43,6 +43,7 @@ dependencies {
androidTestImplementation(Dependencies.InstrumentationTests.Core)
androidTestImplementation(Dependencies.InstrumentationTests.Espresso)
androidTestImplementation(Dependencies.InstrumentationTests.Rules)
androidTestImplementation(Dependencies.InstrumentationTests.JUnit)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed for ActivityScenarioRule.

@zach-klippenstein zach-klippenstein marked this pull request as ready for review January 22, 2021 17:44
@zach-klippenstein
Copy link
Collaborator Author

Tests seem to be flaking on 23 and 26:

radiography.test.RadiographyUiTest > when_includingPii_then_hierarchyContainsText[test(AVD) - 8.0.0] FAILED 
	expected to contain: Yo
	but was            :

@zach-klippenstein zach-klippenstein merged commit 12547e3 into main Jan 22, 2021
@zach-klippenstein zach-klippenstein deleted the zachklipp/run-ui-tests-android-11 branch January 22, 2021 20:25
@zach-klippenstein zach-klippenstein mentioned this pull request Jan 22, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyricau pyricau pyricau approved these changes

@jamesmosley55 jamesmosley55 Awaiting requested review from jamesmosley55

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zach-klippenstein @pyricau