Update the compose sample to use the latest compose version. #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this does not actually change the version of compose that the library is compiled against. This ensures that the existing release still works with the newer compose version.
zach-klippenstein
requested review from
jamesmosley55,
pyricau and
a team
as code owners
pyricau
approved these changes
Sep 17, 2020
pyricau
reviewed
Sep 17, 2020
| @@ -6,7 +6,7 @@ plugins { | |||
| } | |||
|
|
|||
| /** Use a separate property for the sample so we can test with different versions easily. */ | |||
| val sampleComposeVersion = Versions.Compose | |||
| val sampleComposeVersion = "1.0.0-alpha03" | |||
There was a problem hiding this comment.
could also extract this as "Versions.MinSupportedCompose" ?
There was a problem hiding this comment.
Sure, although it would be MaxSupportedCompose. Maybe we should extract min/max versions and run both in CI?
patrickyin
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this does not actually change the version of compose that the library is compiled against. This ensures that the existing release still works with the newer compose version.