Rails::Auth::Monitor::Middleware #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
tarcieri/monitor-middleware
branch
from
5c88299
to
cbff918
Compare
Adds a middleware which fires a callback for every request which includes the Rack environment and whether or not the request was authorized. Useful for logging AuthZ status of each request and/or reporting AuthZ failures to e.g. an alerting system.
tarcieri
force-pushed
the
tarcieri/monitor-middleware
branch
from
cbff918
to
87dfed9
Compare
| raise | ||
| end | ||
|
|
||
| @callback.call(env, true) |
There was a problem hiding this comment.
Might be neat to actually pass the matcher used to authorize the request here
There was a problem hiding this comment.
Ended up leaving this as-is, but doing a separate PR that allows us to retrieve which matcher authorized the request: #34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a middleware which fires a callback for every request which includes the Rack environment and whether or not the request was authorized.
Useful for logging AuthZ status of each request and/or reporting AuthZ failures to e.g. an alerting system.