Bump supported Ruby versions #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbyczkowski
force-pushed
the
mbyczkowski/bump-rubies
branch
2 times, most recently
from
7023337
to
8dba176
Compare
drcapulet
reviewed
Nov 25, 2019
Comment on lines
-11
to
+9
| return unless certs | ||
| OpenSSL::X509::Certificate.new(extract_der(certs[0])).freeze | ||
| end | ||
|
|
||
| private | ||
|
|
||
| def extract_der(cert) | ||
| stringio = StringIO.new | ||
| cert.derEncode(stringio.to_outputstream) | ||
| stringio.string | ||
| return if certs.nil? || certs.empty? | ||
| OpenSSL::X509::Certificate.new(certs[0].get_encoded).freeze |
There was a problem hiding this comment.
Is this change backwards compatible?
There was a problem hiding this comment.
yes, it uses a more generic java.security.cert.Certificate abstract class to get the encoding (which has been around in Java for a looong time), rather than expect the instance of sun.security.x509.X509CertImpl.
mbyczkowski
force-pushed
the
mbyczkowski/bump-rubies
branch
4 times, most recently
from
b1f923f
to
3b12228
Compare
mbyczkowski
commented
Nov 26, 2019
| env: JRUBY_OPTS="--debug" # for simplecov | ||
| - rvm: jruby-9.1 | ||
| env: JRUBY_OPTS="--debug" # for simplecov | ||
| - rvm: jruby |
There was a problem hiding this comment.
@drcapulet After reading JRuby Roadmap, I think we should only support jruby-9.2 here (which is equivalent to jruby for now). Thoughts?
Closed
mbyczkowski
force-pushed
the
mbyczkowski/bump-rubies
branch
2 times, most recently
from
df66dc8
to
de7b23a
Compare
drcapulet
approved these changes
Dec 2, 2019
rails-auth.gemspec
Outdated
| @@ -29,6 +29,6 @@ Gem::Specification.new do |spec| | |||
|
|
|||
| spec.add_runtime_dependency "rack" | |||
|
|
|||
| spec.add_development_dependency "bundler", "~> 1.10" | |||
| spec.add_development_dependency "bundler", [">= 1.10", "< 3"] | |||
There was a problem hiding this comment.
nit: make this just spec.add_development_dependency "bundler", ">= 1.10", "< 3"
Comment on lines
-11
to
+9
| return unless certs | ||
| OpenSSL::X509::Certificate.new(extract_der(certs[0])).freeze | ||
| end | ||
|
|
||
| private | ||
|
|
||
| def extract_der(cert) | ||
| stringio = StringIO.new | ||
| cert.derEncode(stringio.to_outputstream) | ||
| stringio.string | ||
| return if certs.nil? || certs.empty? | ||
| OpenSSL::X509::Certificate.new(certs[0].get_encoded).freeze |
| env: JRUBY_OPTS="--debug" # for simplecov | ||
| - rvm: jruby-9.1 | ||
| env: JRUBY_OPTS="--debug" # for simplecov | ||
| - rvm: jruby |
- Bumped MRI Rubies to the ones that are still supported - Bumped JRuby to the last release (as it's recommended by JRuby's Roadmap). This also required a change to how Java certificates are created in test (sun.security.x509.X509CertImpl can no longer be directly instantiated). - Allowed the use of Bundler 2
mbyczkowski
force-pushed
the
mbyczkowski/bump-rubies
branch
from
de7b23a
to
0634380
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java certificates are created in test (sun.security.x509.X509CertImpl
can no longer be directly instantiated).