how can i get status code 204 on failure in retrofit 2 and empty body

[umeshpatel046]

What kind of issue is this?

• Question. This issue tracker is not the place for questions. If you want to ask how to do
  something, or to understand why something isn't working the way you expect it to, use Stack
  Overflow. https://stackoverflow.com/questions/tagged/retrofit

• Bug report. If you’ve found a bug, spend the time to write a failing test. Bugs with tests
  get fixed. Here’s an example: https://gist.github.com/swankjesse/6608b4713ad80988cdc9

• Feature Request. Start by telling us what problem you’re trying to solve. Often a solution
  already exists! Don’t send pull requests to implement new features without first getting our
  support. Sometimes we leave features out on purpose to keep the project small.

[JakeWharton]

A 204 should not go to onFailure. Your converter and declared body type should be prepared to handle this code should the server return it.

…

On Sat, Sep 23, 2017 at 6:32 PM Casey Kulm ***@***.***> wrote: Do you have a failing test case? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2494 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEEEdjvDWVqCDb42zeqZNhwbvrzGEVUks5slYb1gaJpZM4PhpHP> .

[JakeWharton]

Without a failing test or example it's impossible to know what's going on.

[lianshengzhang001]

A 204 should not go to onFailure. Your converter and declared body type
should be prepared to handle this code should the server return it.

I've got the same problem.
I am using retrofit2.3.0

OkHttpCall parseResponse

if (code == 204 || code == 205) {
  rawBody.close();
  return Response.success(null, rawResponse);
}

ExceptionCatchingRequestBody catchingBody = new ExceptionCatchingRequestBody(rawBody);
try {
  T body = serviceMethod.toResponse(catchingBody);
  return Response.success(body, rawResponse);
} catch (RuntimeException e) {
  // If the underlying source threw an exception, propagate that rather than indicating it was
  // a runtime exception.
  catchingBody.throwIfCaught();
  throw e;
}

---

my converter

@Override
public T convert(ResponseBody value) throws IOException {
    JsonReader jsonReader = gson.newJsonReader(value.charStream());
    try {
        T result = adapter.read(jsonReader);
        if (result == null && type != Void.class) {
            throw new RuntimeException("response cannot be null");
        }
        return result;
    } finally {
        value.close();
    }
}

---

some callback

                @Override
                public void onSuccess(List<Model> lst) {
                    if (list!=null) //here is the crash point, so many pointer if 
                    {
                    }
                }

---

thinking about the following case
api request some data, server return 204 or 205,client parseResponse hit 204 or 205 branch, onSuccess is called, my onSuccess get a null reference crash. my converter doesn't have chance to handle the status, never get the 204 or 205 RuntimeException("response cannot be null").
I think this is a bug.

[JakeWharton]

If you have the same problem then perhaps you can write a failing test case for it?

[umeshpatel046]

This issue has been sloved

…

On Mon, Oct 30, 2017 at 9:46 AM, Jake Wharton ***@***.***> wrote: Closed #2494 <#2494>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2494 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJ4nbJXEOMvg0UEloiMyh0npCbQ9nwPWks5sxU2OgaJpZM4PhpHP> .

-- *Thanks & Regards.Umesh PatelAndroid DeveloperCell: +91(0)8375066078*