Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add headers-only logging level. #269

Merged
merged 1 commit into from Jul 12, 2013
Merged

Add headers-only logging level. #269

merged 1 commit into from Jul 12, 2013

Conversation

JakeWharton
Copy link
Member

@codefromthecrypt
Copy link

good idea

pforhan
pforhan reviewed Jul 12, 2013
View reviewed changes
retrofit/src/main/java/retrofit/Utils.java
*/
static Request readBodyToBytesIfNecessary(Request request) throws IOException {
TypedOutput body = request.getBody();
if (body == null || body instanceof TypedByteArray) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: could be one line.

@codefromthecrypt codefromthecrypt mentioned this pull request Jul 12, 2013
Closed
@pforhan
Copy link
Contributor

pforhan commented Jul 12, 2013

LGTM.

dnkoutso added a commit that referenced this pull request Jul 12, 2013
@dnkoutso
Merge pull request #269 from square/jw/headers
86753a5 
Add headers-only logging level.
@dnkoutso dnkoutso merged commit 86753a5 into master Jul 12, 2013
@dnkoutso dnkoutso deleted the jw/headers branch July 12, 2013 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JakeWharton @codefromthecrypt @pforhan @dnkoutso