Abstract HTTP entity (de)serializaton to converters. #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -66,5 +66,17 @@ | |||
| public ServerError(String message) { | |||
| this.message = message; | |||
| } | |||
|
|
|||
| @Override public boolean equals(Object o) { | |||
There was a problem hiding this comment.
do you need to override these?
There was a problem hiding this comment.
It made the test go green. I suppose I should actually figure out why object comparison was being used and correct that.
This was referenced Oct 16, 2012
|
Ready for re-review. All tests pass locally. Will have to investigate what's up with Travis once I get off airplane Wi-Fi. |
|
But still don't merge it yet! |
|
|
||
| @SuppressWarnings("unchecked") | ||
| @SuppressWarnings("unchecked") // Type is extracted from generic properties so cast is safe. |
|
LGTM |
This allows for specifying different serializations formats for use over the wire. This commit also lays the groundwork for future synchronous invocation.
edenman
added a commit
that referenced
this pull request
Oct 17, 2012
Abstract HTTP entity (de)serializaton to converters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for specifying different serializations formats for use over the wire.
This commit also lays the groundwork for future synchronous invocation.