-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to v4.1.2 #76
chore: upgrade to v4.1.2 #76
Conversation
package.json
Outdated
"typescript": "^4.5.5", | ||
"vitest": "^0.34.1" | ||
}, | ||
"dependencies": { | ||
"cookie-storage": "^6.1.0" | ||
}, | ||
"peerDependencies": { | ||
"svelte": "^3.0.0" | ||
"svelte": "^4.1.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would block consumers from using this unless they had over 4.1.2
Instead we want to use semantic versioning to declare a range of compatible svelte versions from 3 to 4
https://nodejs.org/es/blog/npm/peer-dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I updated this with a range from 3.0.0 -> 5.0.0 bfe52ea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change peer dependency declaration to retain support for svelte 3
Upgrade to v4.1.2