File handle leak when exception in QueueFile construction #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
occurred during construction of QueueFile. This issue was discovered when attempting to delete the file associated with the QueueFile. The file was locked and couldn't be deleted (this only occurs on Windows as Linux does not prevent deletion). In the fix, if any exceptions occur during the construction of QueueFile, the random access file is closed before returning.
|
Appears there is a new issue with errorprone (unrelated to these changes) which is causing Travis CI to fail. The unit tests can be updated to use ArrayDeque versus LinkedList to solve this. |
|
We can fix that in a separate PR. The error-prone version should have been
pinned so new checks don't fail on existing code.
…On Tue, Nov 28, 2017 at 3:27 PM Chris Smith ***@***.***> wrote:
Appears there is a new issue with errorprone (unrelated to these changes)
which is causing Travis CI to fail. The unit tests can be updated to use
ArrayDeque versus LinkedList to solve this.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#179 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAEEEYsP5jAtSbDtvAznlZMOKELM_H0Vks5s7GzBgaJpZM4Qt2Qt>
.
|
|
sorry, that failure was my fault. Is it alright to use try-with-resources? Tell Java 6 users to use desugar or similar? |
|
I don't think we should impose that just yet. Maybe in another year once D8 is widely deployed. |
|
oh, sorry, i read this wrong. looks good. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue where a file handle was being leaked when an exception occurred during construction of QueueFile.
This issue was discovered when attempting to delete the file associated
with the QueueFile. The file was locked and couldn't be deleted (this
only occurs on Windows as Linux does not prevent deletion).
In the fix, if any exceptions occur during the construction of
QueueFile, the random access file is closed before returning.