Add a new format which can support files longer than 2GB. #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both the old format and the new format can be read by QueueFile. Opening an old file will automatically use the old format. New files automatically receive the new format unless a boolean is specified to force the legacy format.
JakeWharton
force-pushed
the
jw/elongate
branch
from
4909c79
to
10be405
Compare
f2prateek
reviewed
Oct 11, 2016
| * | ||
| * Header (32 bytes): | ||
| * 1 bit Versioned indicator [0 = legacy (see "Legacy Header"), 1 = versioned] | ||
| * 31 bits Version, always 1 |
There was a problem hiding this comment.
31 bits seems excessive. I think 15 is sufficient and we could use a short instead. Though the overhead of adding code to deal with short just for this might not be worth it.
There was a problem hiding this comment.
This makes the header an even 32 bytes
Behavior and tests in a separate PR |
pforhan
reviewed
Oct 11, 2016
| @@ -581,8 +673,8 @@ public void clear() throws IOException { | |||
|
|
|||
| if (zero) { | |||
| // Zero out data. | |||
| raf.seek(HEADER_LENGTH); | |||
| raf.write(ZEROES, 0, INITIAL_LENGTH - HEADER_LENGTH); | |||
| raf.seek(headerLength); | |||
There was a problem hiding this comment.
Is it worth saying (on this method or in the class docs) that we don't ever upgrade from legacy to modern format?
There was a problem hiding this comment.
That won't be true when we're done. If legacy format isn't forced queues will be upgraded.
|
Nice work, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the old format and the new format can be read by QueueFile. Opening an old file will automatically use the old format. New files automatically receive the new format unless a boolean is specified to force the legacy format.
Closes #47.