Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FrozenFrameOnTouchDetector frame timestamp #12

Closed
pyricau opened this issue Sep 28, 2021 · 0 comments · Fixed by #14
Closed

FrozenFrameOnTouchDetector frame timestamp #12

pyricau opened this issue Sep 28, 2021 · 0 comments · Fixed by #14

Comments

@pyricau
Copy link
Member

pyricau commented Sep 28, 2021

Currently FrozenFrameOnTouchDetector listens to ACTION_DOWN events and schedules a frame callback from there, combined with a post at front of queue, and logs a "frozen frame" if the time from down being issued to the end time is greater than 700. This seems wrong as we're scheduling for another frame instead of relying on "end of current frame" as frame end. We probably don't want to rely on frame metrics here, we just want to know how long things were blocked for. A post at front (not async) from event handling should be enough.

pyricau added a commit that referenced this issue Sep 28, 2021
We were incorrectly hooking into the next frame. We're already in a frame when handling input.

Fixes #12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant