This repository has been archived by the owner on Apr 16, 2021. It is now read-only.
Added @CheckResult where it matters #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanniktech
reviewed
May 30, 2018
| public abstract boolean canStoreSecurely(); | ||
|
|
||
| /** | ||
| * Writes a value to secure storage. Must check {@link #canStoreSecurely()} before subscribing. | ||
| */ | ||
| @CheckResult |
There was a problem hiding this comment.
for rxjava apis we could use @CheckReturnValue it's an annotation from rxjava
There was a problem hiding this comment.
I would avoid bespoke annotations that are unlikely to be supported by most tools.
There was a problem hiding this comment.
It is for instance supported by Android Lint. Findbugs supports it too if I recall correctly.
There was a problem hiding this comment.
The only reason that annotation exists is because RxJava won't take a dependency on something like androidx annotations or error prone annotations. I don't see a reason to promote a random annotation over one shared by tens of thousands of projects.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.