This repository has been archived by the owner on Apr 16, 2021. It is now read-only.
Issue #52 Use a stronger encryption padding if possible. #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What are the backwards compatibility implications of this? |
|
I'll double check locally, thanks! |
|
It looks like it does have some breaking changes for backwards compatibility, locally I'm going to go with failing back to the weaker cipher on read as well as write. Let me know if that's ok for the library as a whole or if it's better to just decline the PR for now. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for Issue #52 . If the build config is 23 or higher use the stronger encryption padding.