Allow GrpcClient to be implemented on all platforms #2677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oldergod
force-pushed
the
bquenaudon.2023-10-12.grpcclientopenforreal
branch
from
46c314a
to
5cf9587
Compare
|
Jesse is telling me we could create the option at the OkHttp level. We'll pair next week and see how it goes. |
swankjesse
approved these changes
Oct 17, 2023
| public synthetic fun <init> (Lokhttp3/Call$Factory;Lokhttp3/HttpUrl;JLkotlin/jvm/internal/DefaultConstructorMarker;)V | ||
| public final fun create (Lkotlin/reflect/KClass;)Lcom/squareup/wire/Service; | ||
| public final fun newBuilder ()Lcom/squareup/wire/GrpcClient$Builder; | ||
| public fun <init> ()V |
There was a problem hiding this comment.
Suggested change
| public fun <init> ()V | |
| public fun <init> ()V | |
| public final fun create (Lkotlin/reflect/KClass;)Lcom/squareup/wire/Service; | |
| public final fun newBuilder ()Lcom/squareup/wire/GrpcClient$Builder;``` |
Comment on lines
42
to
46
| public final class com/squareup/wire/GrpcClientKt { | ||
| public static final fun create (Lcom/squareup/wire/GrpcClient;Lkotlin/reflect/KClass;)Lcom/squareup/wire/Service; | ||
| public static final fun newBuilder (Lcom/squareup/wire/GrpcClient;)Lcom/squareup/wire/GrpcClient$Builder; | ||
| } | ||
|
|
There was a problem hiding this comment.
This shouldn’t be a public API.
Suggested change
| public final class com/squareup/wire/GrpcClientKt { | |
| public static final fun create (Lcom/squareup/wire/GrpcClient;Lkotlin/reflect/KClass;)Lcom/squareup/wire/Service; | |
| public static final fun newBuilder (Lcom/squareup/wire/GrpcClient;)Lcom/squareup/wire/GrpcClient$Builder; | |
| } |
oldergod
force-pushed
the
bquenaudon.2023-10-12.grpcclientopenforreal
branch
from
5cf9587
to
5ee8d73
Compare
Including JVM or common
oldergod
force-pushed
the
bquenaudon.2023-10-12.grpcclientopenforreal
branch
from
5ee8d73
to
82e565a
Compare
|
Updated the code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including JVM or common. Following up on #2505 and we didn't quite do that.
Obviously breaking some APIs. Most common breaking change for client users is around having now to import
newCallorcreatefor they became extension functions.I am not really sure it's the right way.
Goals are to let anybody implement their own GrpcClient on common, jvm, js, native. Right now, that's only possible for js and native. With this PR, I think all would be cool.
Fixes #2484
cc @iTaysonLab @RaphaelJenni