Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OutputT should be nullable #59

Closed
zach-klippenstein opened this issue Oct 14, 2019 · 0 comments · Fixed by #49
Closed

OutputT should be nullable #59

zach-klippenstein opened this issue Oct 14, 2019 · 0 comments · Fixed by #49
Assignees
@zach-klippenstein
Milestone
v1.0.0-beta.1

Comments

@zach-klippenstein
Copy link
Collaborator

square/workflow#334 removed non-null restriction from all other workflow types. No reason for Output to have it either.
zach-klippenstein referenced this issue in square/workflow Oct 14, 2019
@zach-klippenstein
WIP: Make OutputT nullable.
c464a54 
Closes #671.
zach-klippenstein referenced this issue Jun 18, 2020
@zach-klippenstein
WIP Remove non-null upper bound for OutputT.
0ce36fc 
TODO: This requires migrating integration testing infra over to renderWorkflowIn first.

Fixes https://github.com/square/workflow/issues/671.
zach-klippenstein referenced this issue Jun 26, 2020
@zach-klippenstein
WIP Remove non-null upper bound for OutputT.
cb0563d 
TODO: This requires migrating integration testing infra over to renderWorkflowIn first.

Fixes https://github.com/square/workflow/issues/671.
zach-klippenstein referenced this issue Jun 26, 2020
@zach-klippenstein
Remove non-null upper bound for OutputT.
e121a1c 
Fixes https://github.com/square/workflow/issues/671.
zach-klippenstein referenced this issue Jun 26, 2020
@zach-klippenstein
Remove non-null upper bound for OutputT.
6ebfd8a 
Fixes https://github.com/square/workflow/issues/671.
zach-klippenstein referenced this issue Jun 27, 2020
@zach-klippenstein
Remove non-null upper bound for OutputT.
aa13453 
TODO add tests for null output

Fixes https://github.com/square/workflow/issues/671.
@zach-klippenstein zach-klippenstein transferred this issue from square/workflow Jun 27, 2020
@zach-klippenstein zach-klippenstein added this to the v1.0.0 milestone Jun 27, 2020
@zach-klippenstein zach-klippenstein self-assigned this Jun 27, 2020
zach-klippenstein added a commit that referenced this issue Jun 27, 2020
@zach-klippenstein
Remove non-null upper bound for OutputT.
5241a14 
Fixes #59.
zach-klippenstein added a commit that referenced this issue Jun 27, 2020
@zach-klippenstein
Remove non-null upper bound for OutputT.
9216a69 
Fixes #59.
@zach-klippenstein zach-klippenstein mentioned this issue Jun 27, 2020
Merged
zach-klippenstein added a commit that referenced this issue Jun 27, 2020
@zach-klippenstein
Remove non-null upper bound for OutputT.
e49357e 
Fixes #59.
zach-klippenstein added a commit that referenced this issue Feb 4, 2021
@zach-klippenstein
Merge pull request #59 from square/zachklipp/upgrade-compose
ebeeb8b 
Upgrade Compose and Kotlin to latest version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zach-klippenstein zach-klippenstein

Labels
None yet
Projects
None yet
Milestone
v1.0.0-beta.1
Development

Successfully merging a pull request may close this issue.

Remove non-null upper bound for OutputT. square/workflow-kotlin
1 participant
@zach-klippenstein