Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve running(Worker) inconsistencies #611

Open
zach-klippenstein opened this issue Mar 10, 2020 · 2 comments
Open

Resolve running(Worker) inconsistencies #611

zach-klippenstein opened this issue Mar 10, 2020 · 2 comments

Comments

@zach-klippenstein
Copy link
Collaborator 

MyWorker()
  .running(context, "key")

This requires turning Worker in Kotlin into an abstract class and making Worker.run protected, to reduce confusion.

We need to something similar for Workflow, see square/workflow#996.
@dhavalshreyas
Copy link
Collaborator

Fixed on the swift side.

@zach-klippenstein
Copy link
Collaborator Author

We decided to remove this from 1.0 in kotlin since it just added work and confusion and we didn't think this was a very important detail to converge on.

@rjrjr rjrjr transferred this issue from square/workflow Dec 16, 2021
@rjrjr rjrjr mentioned this issue Dec 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zach-klippenstein @dhavalshreyas