Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve render(workflow) inconsistencies #612

Open
rjrjr opened this issue Mar 4, 2020 · 2 comments
Open

Resolve render(workflow) inconsistencies #612

rjrjr opened this issue Mar 4, 2020 · 2 comments

Comments

@rjrjr
Copy link
Contributor

rjrjr commented Mar 4, 2020

// This is the fundamental API. 
// rendered method here requires output type to be Action<...>
let result = MyWorkflow()
    .mapOutput {  }
    .rendered(with: context, key: “key”)

// Convenience for the above,  and probably /maybe the 90% use case
let result = MyWorkflow()
    .rendered(
        with: context,
        key: “key”,
        onOutput: {  }
    )

Unclear, though, what impact the mapOutput call has / should have on workflow equivalence.
While sorting this out, keep in mind the intimately related conversation in square/workflow#961. It would be pretty odd to land in different places.

Also slightly related to square/workflow#544?

This change should also be applied to Workers. See #611.

@dhavalshreyas
Copy link
Collaborator

Decision is to keep mapOutput on the swift side.

@zach-klippenstein
Copy link
Collaborator

We decided to remove this from 1.0 in kotlin since it just added work and confusion and we didn't think this was a very important detail to converge on.

@rjrjr rjrjr transferred this issue from square/workflow Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants