Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write a lint check to prevent accessing render's state inside actions #74

Open
zach-klippenstein opened this issue Feb 13, 2020 · 2 comments
Open

Write a lint check to prevent accessing render's state inside actions #74

zach-klippenstein opened this issue Feb 13, 2020 · 2 comments
Labels
enhancement New feature or request lint We wish for a lint check

Comments

@zach-klippenstein
Copy link
Collaborator

Wrong:

action { nextState = state.copy() }

Right:

action { nextState = nextState.copy() }
@SalvatoreT
Copy link
Contributor

I would like this.

@zach-klippenstein
Copy link
Collaborator Author

Lint checks shouldn't block 1.0.0.

@rjrjr rjrjr transferred this issue from square/workflow Jun 28, 2020
@zach-klippenstein zach-klippenstein added the enhancement New feature or request label Jul 12, 2020
@rjrjr rjrjr added the lint We wish for a lint check label Oct 16, 2020
zach-klippenstein added a commit that referenced this issue Feb 4, 2021
@zach-klippenstein
Merge pull request #74 from square/zachklipp/upgrade-gradle
a02e6c8 
Upgrade Gradle to latest version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request lint We wish for a lint check
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zach-klippenstein @SalvatoreT @rjrjr