Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin 1.5.0 #417

Merged
merged 2 commits into from May 10, 2021
Merged

Kotlin 1.5.0 #417

merged 2 commits into from May 10, 2021

Conversation

vRallev
Copy link
Collaborator

@vRallev vRallev commented May 5, 2021

You might want to wait until we're ready internally, though.

@vRallev vRallev requested review from zach-klippenstein and a team as code owners May 5, 2021 16:36
@CLAassistant
Copy link

CLAassistant commented May 5, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@zach-klippenstein zach-klippenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These abi changes are baffling to me, but LG.

trace-encoder/api/trace-encoder.api Outdated Show resolved Hide resolved
workflow-core/api/workflow-core.api Outdated Show resolved Hide resolved
workflow-core/api/workflow-core.api Outdated Show resolved Hide resolved
Copy link
Collaborator

@zach-klippenstein zach-klippenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this again - please rebase onto #419 to get rid of all the incorrect api diffs.

@zach-klippenstein zach-klippenstein changed the base branch from main to zachklipp/update-binary-validator May 10, 2021 15:32
@zach-klippenstein
Copy link
Collaborator

I've rebased both the branch and the PR onto #419.

Base automatically changed from zachklipp/update-binary-validator to main May 10, 2021 16:30
@zach-klippenstein
Copy link
Collaborator

Anyone wanna try this out as a snapshot internally?

@vRallev
Copy link
Collaborator Author

vRallev commented May 10, 2021

Anyone wanna try this out as a snapshot internally?

I will run a full CI build with it.

@vRallev
Copy link
Collaborator Author

vRallev commented May 10, 2021

Internal build is green.

@zach-klippenstein
Copy link
Collaborator

I think we're good to merge this then.

@vRallev
Copy link
Collaborator Author

vRallev commented May 10, 2021

I think we're good to merge this then.

Up to you, but I would wait until we rolled out 1.5 internally.

@zach-klippenstein
Copy link
Collaborator

zach-klippenstein commented May 10, 2021

We've verified that even if we merge this, cut a release, and bring the release in internally, it doesn't break ci so is very likely completely safe. Doesn't seem like holding off brings us much.

I'll let @rjrjr break the tie.

@rjrjr rjrjr merged commit 6e2677b into main May 10, 2021
@rjrjr rjrjr deleted the ralf/1-5 branch May 10, 2021 21:54
@vRallev
Copy link
Collaborator Author

vRallev commented May 10, 2021

We've verified that even if we merge this, cut a release, and bring the release in internally, it doesn't break ci so is very likely completely safe. Doesn't seem like holding off brings us much.

I'll let @rjrjr break the tie.

I did not test this release with Kotlin 1.4 internally, only with 1.5 that we plan to roll out next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants