New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kotlin 1.5.0 #417
Kotlin 1.5.0 #417
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These abi changes are baffling to me, but LG.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this again - please rebase onto #419 to get rid of all the incorrect api diffs.
959f2ac
to
4d7c35c
Compare
I've rebased both the branch and the PR onto #419. |
Anyone wanna try this out as a snapshot internally? |
I will run a full CI build with it. |
Internal build is green. |
I think we're good to merge this then. |
Up to you, but I would wait until we rolled out 1.5 internally. |
We've verified that even if we merge this, cut a release, and bring the release in internally, it doesn't break ci so is very likely completely safe. Doesn't seem like holding off brings us much. I'll let @rjrjr break the tie. |
I did not test this release with Kotlin 1.4 internally, only with 1.5 that we plan to roll out next week. |
You might want to wait until we're ready internally, though.