Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades leak canary, testing, androidx lifecycle. #634

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Conversation

rjrjr
Copy link
Contributor

@rjrjr rjrjr commented Jan 19, 2022

Note that we hold off on upgrading androidx activity, appcompat, etc. Those push androidx core past 1.6.0, which breaks https://github.com/cashapp/paparazzi. We should hold off until they catch up, which should happen soon after AS Bumblebee freezes.

build.gradle.kts Outdated Show resolved Hide resolved
@rjrjr rjrjr changed the title DNM: Upgrade various androidx versions. Upgrade various androidx versions. Jan 19, 2022
@rjrjr rjrjr changed the base branch from main to ray/api-wtf January 19, 2022 21:54
Base automatically changed from ray/api-wtf to main January 19, 2022 22:57
@rjrjr rjrjr force-pushed the ray/upgrades branch 2 times, most recently from 1c65e56 to 1a9569b Compare January 20, 2022 00:33
@rjrjr rjrjr changed the title Upgrade various androidx versions. Upgrade various dependencies, mostly androidx. Jan 20, 2022
@rjrjr rjrjr force-pushed the ray/upgrades branch 2 times, most recently from df884e6 to e597b33 Compare January 20, 2022 01:32
@rjrjr rjrjr marked this pull request as ready for review January 20, 2022 01:32
@rjrjr rjrjr requested review from zach-klippenstein and a team as code owners January 20, 2022 01:32
Copy link

@vgonda vgonda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on board with upgrades

@@ -1,7 +1,6 @@
android {
defaultConfig {
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
testInstrumentationRunnerArgument "listener", "leakcanary.FailTestOnLeakRunListener"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming removing this was somehow related to the upgrades?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh it's because we're now chaining DetectLeaksAfterTestSuccess with the test rule.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And FailTestOnLeakRunListener just flat out doesn't work w/upgraded test dependencies.

@rjrjr
Copy link
Contributor Author

rjrjr commented Jan 20, 2022

This is consistently failing:

* What went wrong:
Execution failed for task ':trace-encoder:kaptGenerateStubsKotlin'.
> Error while evaluating property 'filteredArgumentsMap' of task ':trace-encoder:kaptGenerateStubsKotlin'
   > Could not resolve all files for configuration ':trace-encoder:kapt'.
      > Could not download guava-30.1.1-jre.jar (com.google.guava:guava:30.1.1-jre)
         > Could not get resource 'https://repo.maven.apache.org/maven2/com/google/guava/guava/30.1.1-jre/guava-30.1.1-jre.jar'.
            > Could not GET 'https://repo.maven.apache.org/maven2/com/google/guava/guava/30.1.1-jre/guava-30.1.1-jre.jar'.
               > Connection reset

Needless to say we have no direct dependencies on guava, so I imagine we have a friend at Google who is pulling it for us transitively. Good times.

@rjrjr
Copy link
Contributor Author

rjrjr commented Jan 20, 2022

This is consistently failing:

* What went wrong:
Execution failed for task ':trace-encoder:kaptGenerateStubsKotlin'.
> Error while evaluating property 'filteredArgumentsMap' of task ':trace-encoder:kaptGenerateStubsKotlin'
   > Could not resolve all files for configuration ':trace-encoder:kapt'.
      > Could not download guava-30.1.1-jre.jar (com.google.guava:guava:30.1.1-jre)
         > Could not get resource 'https://repo.maven.apache.org/maven2/com/google/guava/guava/30.1.1-jre/guava-30.1.1-jre.jar'.
            > Could not GET 'https://repo.maven.apache.org/maven2/com/google/guava/guava/30.1.1-jre/guava-30.1.1-jre.jar'.
               > Connection reset

Needless to say we have no direct dependencies on guava, so I imagine we have a friend at Google who is pulling it for us transitively. Good times.

Bah, this is happening a lot on master too, right after green PR runs. Something is rotten in GHA land, as usual.

@rjrjr
Copy link
Contributor Author

rjrjr commented Jan 24, 2022

Going to hold off on a lot of this. Bumping appcompat also bumps core past 1.6.0, which breaks https://github.com/cashapp/paparazzi. Shouldn't do that w/o a compelling need.

@jrodbx expects to be able to address that once AS Bumblebee is released.

@rjrjr rjrjr changed the title Upgrade various dependencies, mostly androidx. Upgrades leack canary, testing, androidx lifecycle. Jan 25, 2022
Note that we hold off on upgrading androidx activity, appcompat, etc. Those push androidx core past 1.6.0, which breaks https://github.com/cashapp/paparazzi. We should hold off until they catch up, which should happen soon after AS Bumblebee freezes.
@rjrjr rjrjr changed the title Upgrades leack canary, testing, androidx lifecycle. Upgrades leak canary, testing, androidx lifecycle. Jan 25, 2022
@rjrjr rjrjr merged commit c84b71a into main Jan 25, 2022
@rjrjr rjrjr deleted the ray/upgrades branch January 25, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants