-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrades leak canary, testing, androidx lifecycle. #634
Conversation
1c65e56
to
1a9569b
Compare
df884e6
to
e597b33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm on board with upgrades
@@ -1,7 +1,6 @@ | |||
android { | |||
defaultConfig { | |||
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" | |||
testInstrumentationRunnerArgument "listener", "leakcanary.FailTestOnLeakRunListener" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming removing this was somehow related to the upgrades?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh it's because we're now chaining DetectLeaksAfterTestSuccess
with the test rule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And FailTestOnLeakRunListener
just flat out doesn't work w/upgraded test dependencies.
This is consistently failing:
Needless to say we have no direct dependencies on guava, so I imagine we have a friend at Google who is pulling it for us transitively. Good times. |
Bah, this is happening a lot on master too, right after green PR runs. Something is rotten in GHA land, as usual. |
Going to hold off on a lot of this. Bumping appcompat also bumps core past 1.6.0, which breaks https://github.com/cashapp/paparazzi. Shouldn't do that w/o a compelling need. @jrodbx expects to be able to address that once AS Bumblebee is released. |
Note that we hold off on upgrading androidx activity, appcompat, etc. Those push androidx core past 1.6.0, which breaks https://github.com/cashapp/paparazzi. We should hold off until they catch up, which should happen soon after AS Bumblebee freezes.
Note that we hold off on upgrading androidx activity, appcompat, etc. Those push androidx core past 1.6.0, which breaks https://github.com/cashapp/paparazzi. We should hold off until they catch up, which should happen soon after AS Bumblebee freezes.