Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss: Allow "input" to update for a workflow in a ContainerViewController/WorkflowHost #351

Closed
davidapgar opened this issue May 16, 2019 · 1 comment
Assignees

Comments

@davidapgar
Copy link
Collaborator

When rendering a child workflow, the "input" (ie: the Workflow) is updated each time (allowing it to handle an update to its input, via workflowDidChange).

Currently, the root workflow hosted in a WorkflowHost (and ContainerViewController) does not provide any means to update the Workflow - it is just the root workflow, so the outside doesn't have a path to update the input.

We should consider adding this (I believe the Android version does have support for this)

@davidapgar davidapgar self-assigned this May 16, 2019
@zach-klippenstein
Copy link
Collaborator

zach-klippenstein commented May 16, 2019

We do, our WorkflowHost takes a ReceiveChannel (Signal) of inputs. Super handy because it also lets the first input be provided asynchronously, which turns out to be a pretty common use case given the way our internal integration works.

Here's the change: https://github.com/square/workflow/pull/282/files#diff-c9e75405c1366dc37bf068c0cd37762c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants