Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Kotlin's ViewBinding to ViewFactory. #1009

Merged
merged 1 commit into from Mar 7, 2020
Merged

Rename Kotlin's ViewBinding to ViewFactory. #1009

merged 1 commit into from Mar 7, 2020

Conversation

zach-klippenstein
Copy link
Collaborator

Closes #988.

@zach-klippenstein zach-klippenstein added the kotlin Affects the Kotlin library. label Mar 6, 2020
@zach-klippenstein zach-klippenstein added this to the v0.24.0 milestone Mar 6, 2020
@zach-klippenstein zach-klippenstein added this to In progress in Workflow via automation Mar 6, 2020
@zach-klippenstein
Copy link
Collaborator Author

As per this Slack discussion with @rjrjr and @steveinflow, we've decided to rename RenderBinding to ViewFactory.

@zach-klippenstein zach-klippenstein force-pushed the zachklipp/renderbinding branch 2 times, most recently from c1c6383 to 2008c39 Compare March 6, 2020 23:56
@zach-klippenstein
Copy link
Collaborator Author

@rjrjr rename is done, ready for another review.

@zach-klippenstein zach-klippenstein changed the title Rename Kotlin's ViewBinding to RenderBinding. Rename Kotlin's ViewBinding to ViewFactory. Mar 6, 2020
rjrjr
rjrjr approved these changes Mar 7, 2020
View reviewed changes
Copy link
Contributor

@rjrjr rjrjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again. I actually like the new name a lot, seems a bit more direct about just what work these things do.

Workflow automation moved this from In progress to Reviewer approved Mar 7, 2020
@zach-klippenstein
Copy link
Collaborator Author

Yea I'm happy with it too.

@zach-klippenstein zach-klippenstein merged commit 2552df0 into master Mar 7, 2020
Workflow automation moved this from Reviewer approved to Done Mar 7, 2020
@zach-klippenstein zach-klippenstein deleted the zachklipp/renderbinding branch March 7, 2020 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjrjr rjrjr rjrjr approved these changes

@tehras tehras Awaiting requested review from tehras

Assignees
No one assigned
Labels
kotlin Affects the Kotlin library.
Projects
Workflow
  
Done
Milestone
v0.24.0
Development

Successfully merging this pull request may close these issues.

Rename ViewBinding to RenderBinding
2 participants
@zach-klippenstein @rjrjr