Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide empty makeInitialState and workflowDidChange when State is Void #1094

Merged
merged 1 commit into from Apr 16, 2020
Merged

Provide empty makeInitialState and workflowDidChange when State is Void #1094

merged 1 commit into from Apr 16, 2020

Conversation

bencochran
Copy link
Collaborator

Essentially a “StatelessWorkflow” without that being a separate type.

#236

dhavalshreyas
dhavalshreyas approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@dhavalshreyas dhavalshreyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yayy! Thank you!

@bencochran bencochran added the swift Affects the Swift library. label Apr 16, 2020
@bencochran bencochran merged commit 7a3ffec into master Apr 16, 2020
@bencochran bencochran deleted the bc/void-workflow branch April 16, 2020 21:32
@JustinDSN JustinDSN mentioned this pull request Apr 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinDSN JustinDSN JustinDSN approved these changes

@dhavalshreyas dhavalshreyas dhavalshreyas approved these changes

@AquaGeek AquaGeek Awaiting requested review from AquaGeek

@amorde amorde Awaiting requested review from amorde

@asthatrivedi asthatrivedi Awaiting requested review from asthatrivedi

Assignees
No one assigned
Labels
swift Affects the Swift library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bencochran @JustinDSN @rjrjr @dhavalshreyas