Remove context.subscribe #1111
Merged
Remove context.subscribe #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinDSN
reviewed
Apr 27, 2020
| // MARK: - Subscriptions | ||
|
|
||
| extension WorkflowNode.SubtreeManager { | ||
| fileprivate final class Subscriptions { |
There was a problem hiding this comment.
The red lines make me happy :D
|
The 8 commits are a little weird. Do we need all of them? Should we squash them into a single commit? |
dhavalshreyas
approved these changes
Apr 27, 2020
| // MARK: - Subscriptions | ||
|
|
||
| extension WorkflowNode.SubtreeManager { | ||
| fileprivate final class Subscriptions { |
There was a problem hiding this comment.
The red lines make me happy :D
We don't need all of them. Some got pulled out into the other PR that introduced |
AquaGeek
force-pushed
the
stromberg/remove-context-subscribe
branch
from
a02a2ec
to
41d6a46
Compare
This has been replaced with SignalWorker.
AquaGeek
force-pushed
the
stromberg/remove-context-subscribe
branch
from
41d6a46
to
6701aaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #1025. It removes
context.subscribealtogether, now that we've migrated our internal clients. This is a breaking change.This finishes the work on #402 / #744.