Update Compose to dev10. #1118
Merged
Update Compose to dev10. #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zach-klippenstein
added
dependencies
zach-klippenstein
force-pushed
the
zachklipp/compose-dev10
branch
from
e2d9ca1
to
e7cf0b3
Compare
| @@ -28,7 +28,7 @@ import org.junit.runner.RunWith | |||
| class HelloBindingTest { | |||
|
|
|||
| // Launches the activity. | |||
| @Rule @JvmField val scenario = ActivityScenarioRule(HelloBindingActivity::class.java) | |||
| @Rule @JvmField val composeRule = AndroidComposeTestRule<HelloBindingActivity>() | |||
There was a problem hiding this comment.
Compose top-level UI test functions now require a ComposeTestRule to be used, or they will throw.
| @@ -84,7 +85,7 @@ internal class ComposeViewFactory<RenderingT : Any>( | |||
| ) | |||
|
|
|||
| // Entry point to the composition. | |||
| composeContainer.setContent { | |||
| composeContainer.setContent(Recomposer.current()) { | |||
There was a problem hiding this comment.
Old method is deprecated.
rjrjr
approved these changes
May 4, 2020
Dev10 finally brings support for coroutines! This is the first compose update in a while to actually bump the compiler version as well as the plugin version, which is why it requires a few more changes to work.
zach-klippenstein
force-pushed
the
zachklipp/compose-dev10
branch
from
e7cf0b3
to
d28651b
Compare
|
Looks like this might be an actual test failure, but the Actions UI isn't even showing a log for this task so I github might just be having issues. |
|
UI test failure is now: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dev10 finally brings support for coroutines!
This is the first compose update in a while to actually bump the compiler version
as well as the plugin version, which is why it requires a few more changes
to work.
Fixes # (issue)
Type of change
Please select at least one
Testing Checklist
How was this change tested?
Checklist: