Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move WorkflowFragment initialization to onViewStateRestored. #1133

Merged
merged 1 commit into from May 8, 2020
Merged

Move WorkflowFragment initialization to onViewStateRestored. #1133

merged 1 commit into from May 8, 2020

Conversation

ychescale9
Copy link
Contributor

Fixes #1122.

Checklist

  • Unit Tests
  • UI Tests
  • Snapshot Tests (iOS only)
  • I have made corresponding changes to the documentation

zach-klippenstein
zach-klippenstein approved these changes May 7, 2020
View reviewed changes
Copy link
Collaborator

@zach-klippenstein zach-klippenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG to me, but letting @rjrjr approve and merge.

@rjrjr rjrjr merged commit e096d14 into square:master May 8, 2020
@rjrjr
Copy link
Contributor

rjrjr commented May 8, 2020

Thanks!

@ychescale9 ychescale9 deleted the yc/workflow-fragment-init branch May 13, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zach-klippenstein zach-klippenstein zach-klippenstein approved these changes

@rjrjr rjrjr rjrjr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WorkflowFragment using deprecated onActivityCreated()
3 participants
@ychescale9 @rjrjr @zach-klippenstein