Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make workflow-ui-android-core declare workflow-runtime as api instead of implementation dependency. #1144

Merged
merged 1 commit into from May 8, 2020

Conversation

zach-klippenstein
Copy link
Collaborator

Fixes #1139.

Checklist

  • Unit Tests
  • UI Tests
  • Snapshot Tests (iOS only)
  • I have made corresponding changes to the documentation

@zach-klippenstein zach-klippenstein added bug Something isn't working dependencies Pull requests that update a dependency file kotlin Affects the Kotlin library. labels May 7, 2020
@zach-klippenstein zach-klippenstein added this to the v1.0.0 milestone May 7, 2020
@zach-klippenstein zach-klippenstein added this to In progress in Workflow via automation May 7, 2020
Workflow automation moved this from In progress to Reviewer approved May 7, 2020
@zach-klippenstein zach-klippenstein merged commit 2657ef4 into master May 8, 2020
Workflow automation moved this from Reviewer approved to Done May 8, 2020
@zach-klippenstein zach-klippenstein deleted the zachklipp/fix-runtimed-dep branch May 8, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file kotlin Affects the Kotlin library.
Projects
Workflow
  
Done
Development

Successfully merging this pull request may close these issues.

Cannot access class 'com.squareup.workflow.diagnostic.WorkflowDiagnosticListener'
2 participants