Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify ViewRegistry to act more like a simple map of rendering type to ViewFactory. #1148

Merged
merged 1 commit into from
May 11, 2020
Merged

Simplify ViewRegistry to act more like a simple map of rendering type to ViewFactory. #1148

merged 1 commit into from
May 11, 2020

Commits on May 11, 2020

  1. Simplify ViewRegistry to act more like a simple map of rendering type… 

    … to ViewFactory.

`ViewRegistry` is now just responsible for returning a `ViewFactory` for a given
rendering type, as well as checking that views returned from the factory have been
correctly bound with `bindShowRendering`. `buildView` has been extracted into an
extension method on `ViewRegistry`.

This change simplifies the responsibility of each `ViewRegistry` implementation. It
also makes `ViewRegistry` more flexible for extension. For example, allows a
Compose-based `ViewFactory` to detect recursive Compose bindings and stay in Compose
instead of jumping back out into the legacy view layer every time.
    @zach-klippenstein
    zach-klippenstein committed May 11, 2020
    Configuration menu
    Copy the full SHA
    9ffea7d View commit details
    Browse the repository at this point in the history