Remove RxJava2 dependency from Workflow Android UI integration. #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zach-klippenstein
force-pushed
the
zachklipp/remove-rxjava
branch
2 times, most recently
from
705b606
to
8a9ca38
Compare
rjrjr
approved these changes
May 11, 2020
kotlin/workflow-ui/core-android/src/main/java/com/squareup/workflow/ui/WorkflowFragment.kt
Show resolved
Hide resolved
zach-klippenstein
force-pushed
the
zachklipp/remove-rxjava
branch
from
8a9ca38
to
eb44937
Compare
Comment on lines
+69
to
+87
| private val result = scope.async { | ||
| session.outputs.first() | ||
| } | ||
|
|
||
| override suspend fun awaitResult(): OutputT = result.await() | ||
|
|
||
| init { | ||
| @Suppress("EXPERIMENTAL_API_USAGE") | ||
| session.renderingsAndSnapshots | ||
| .map { it.snapshot } | ||
| .onEach { lastSnapshot = it } | ||
| .launchIn(scope) | ||
|
|
||
| // Cancel the entire workflow runtime after the first output is emitted. | ||
| // Use the Unconfined dispatcher to ensure the cancellation happens as immediately as possible. | ||
| scope.launch(Dispatchers.Unconfined) { | ||
| result.join() | ||
| scope.cancel(CancellationException("WorkflowRunnerViewModel delivered result")) | ||
| } |
There was a problem hiding this comment.
@rjrjr FYI I just reworked this a bit. The result deferred is now created using async, which is much more straightforward and means we don't have to manually propagate results and exceptions. The cancel-on-output logic is now responsible only for that, which I think makes it easier to read.
rjrjr
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1123.
Checklist