Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kotlin] Rename compose and composeChild to render and renderChild. #293

Merged
merged 1 commit into from
Apr 16, 2019
Merged

[kotlin] Rename compose and composeChild to render and renderChild. #293

merged 1 commit into from
Apr 16, 2019

Conversation

zach-klippenstein
Copy link
Collaborator

Closes #265.

@zach-klippenstein zach-klippenstein added this to the v0.14.0 milestone Apr 16, 2019
@zach-klippenstein zach-klippenstein added this to In progress in Workflow (Kotlin) via automation Apr 16, 2019
@zach-klippenstein zach-klippenstein force-pushed the zachklipp/rename-compose-to-render branch from 63d740c to 75887a4 Compare April 16, 2019 23:26
rjrjr
rjrjr approved these changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@rjrjr rjrjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed a couple of test method / test variable names, nothing important.

@zach-klippenstein
Copy link
Collaborator Author

You missed a couple of test method / test variable names, nothing important.

Already fixed.

@zach-klippenstein zach-klippenstein merged commit b8a80a2 into master Apr 16, 2019
Workflow (Kotlin) automation moved this from In progress to Done Apr 16, 2019
@zach-klippenstein zach-klippenstein deleted the zachklipp/rename-compose-to-render branch April 16, 2019 23:39
@zach-klippenstein zach-klippenstein added the kotlin Affects the Kotlin library. label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qrazhan qrazhan qrazhan approved these changes

@rjrjr rjrjr rjrjr approved these changes

@bencochran bencochran Awaiting requested review from bencochran

@timdonnelly timdonnelly Awaiting requested review from timdonnelly

@davidapgar davidapgar Awaiting requested review from davidapgar

Assignees
No one assigned
Labels
kotlin Affects the Kotlin library.
Projects
No open projects
Workflow (Kotlin)
  
Done
Milestone
v0.14.0
Development

Successfully merging this pull request may close these issues.

[kotlin] Rename compose method and concept in docs to render
3 participants
@zach-klippenstein @qrazhan @rjrjr