Workflow tester improvements #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hods. I initially made it an explicit argument because I thought it increased readability, but after writing a bunch of tests, and occasionally using different names for that argument, since the entire point of the lambda passed to `Workflow.test*` methods is to operator on the `WorkflowTester` I think it's actually more readable as a receiver.
zach-klippenstein
requested review from
vRallev,
davidapgar,
rjrjr and
kirillzh
zach-klippenstein
force-pushed
the
zachklipp/workflow-tester-improvements
branch
from
55d7f00
to
02f72fe
Compare
qrazhan
approved these changes
Apr 25, 2019
kirillzh
reviewed
Apr 25, 2019
| @Suppress("DEPRECATION") | ||
| val cancelled = context.cancel(error) | ||
| if (!cancelled) { | ||
| val cancellationCause = context[Job]!!.getCancellationException() |
There was a problem hiding this comment.
requireNotNull() would give better error message in case of NPE.
There was a problem hiding this comment.
It's not possible to have a null here, since we explicitly give the context a Job on line 262. If it does have a null, someone edited this file and broke something, and I'm not worried about the error message in that case.
|
Neat, neat! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three commits:
I initially made it an explicit argument because I thought it increased readability,
but after writing a bunch of tests, and occasionally using different names for that
argument, since the entire point of the lambda passed to
Workflow.test*methods isto operator on the
WorkflowTesterI think it's actually more readable as a receiver.