Fix the nullability of the returned Workers from Rx extensions. #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vRallev
approved these changes
Apr 26, 2019
kirillzh
reviewed
Apr 26, 2019
| */ | ||
| inline fun <reified T : Any> Single<out T?>.asWorker(key: String = ""): Worker<T> = | ||
| // This !! works because RxJava types don't actually allow nulls, it's just that they can't | ||
| // express that in their types because Java. |
kirillzh
reviewed
Apr 26, 2019
| inline fun <reified T : Any> Single<out T?>.asWorker(key: String = ""): Worker<T> = | ||
| // This !! works because RxJava types don't actually allow nulls, it's just that they can't | ||
| // express that in their types because Java. | ||
| Worker.from(key) { await()!! } |
There was a problem hiding this comment.
Would personally prefer requireNotNull() :)
There was a problem hiding this comment.
I definitely wouldn't want requireNotNull here. requireNotNull throws an IllegalArgumentException. Single should never emit a null. If it did for some reason, it would not be an IllegalArgumentException, something would have gone extremely wrong somewhere and that would be the wrong exception to throw.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.