Rename WorkflowAction.noop() to noAction().

[zach-klippenstein]

Closes #412.

[rjrjr]

Could elaborate a bit in the kdoc, something like:

Returns a [WorkflowAction] that does nothing: no output is emitted, and `render` is called again with the same `state` as last time.

[zach-klippenstein]

Done.

[zach-klippenstein]

@davidapgar @bencochran Does this change make sense in Swift too? Don't want to merge unless we agree on terminology.

[davidapgar]

@davidapgar @bencochran Does this change make sense in Swift too? Don't want to merge unless we agree on terminology.

If I understand what this is correctly, the closest we have in Swift is a AnyWorkflowAction.identity, which is still an action, but one that doesn't change the state at all.

The usage we have for it is where there is an Output from a child that we want to "ignore" in the parent (but still have to map the output to an action).

Is this the same use case? Does a noAction still result in a new render pass?

[zach-klippenstein]

The usage we have for it is where there is an Output from a child that we want to "ignore" in the parent (but still have to map the output to an action).

Is this the same use case? Does a noAction still result in a new render pass?

@davidapgar Exactly. I don't like identity because that's even more opaque than noAction (it's not blindingly obvious that this thing returns a function, which is necessary to understand for that name to make sense).

[davidapgar]

The usage we have for it is where there is an Output from a child that we want to "ignore" in the parent (but still have to map the output to an action).
Is this the same use case? Does a noAction still result in a new render pass?

@davidapgar Exactly. I don't like identity because that's even more opaque than noAction (it's not blindingly obvious that this thing returns a function, which is necessary to understand for that name to make sense).

Makes sense. I'm good with the name (will probably make it AnyWorkflowAction.noAction or a typealias to NoAction in Swift land).