Add Completable.asWorker() operator. #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * The [Completable] will be subscribed to when the [Worker] is started, and disposed when it is | ||
| * cancelled. | ||
| */ | ||
| fun Completable.asWorker(key: String = "") = |
There was a problem hiding this comment.
Key should be required since there is no distinguishing type.
zach-klippenstein
force-pushed
the
zachklipp/completable-asworker
branch
from
375f974
to
978783c
Compare
kirillzh
reviewed
Jun 26, 2019
| * distinguish workers. | ||
| */ | ||
| fun Completable.asWorker(key: String) = | ||
| Worker.createSideEffect(key) { await() } |
kirillzh
approved these changes
Jun 26, 2019
zach-klippenstein
force-pushed
the
zachklipp/completable-asworker
branch
from
978783c
to
9ddb5dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #422.