WorkflowRunner now delivers single result instead of output stream. #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrjr
commented
Jul 16, 2019
...in/workflow-ui-android/src/test/java/com/squareup/workflow/ui/WorkflowRunnerViewModelTest.kt
Show resolved
Hide resolved
rjrjr
force-pushed
the
ray/livedata-attempt-deux-430
branch
2 times, most recently
from
776389d
to
5b4cc94
Compare
Android's configuration changes make it very difficult to craft an API that can catch all output values and also avoid double-processing of them, and each such API we've come up with is very confusing. The cognitive cost outweighs the benefit of allowing the Activity or Fragment to consume a stream of outputs — if that's even a benefit! So far we have no use cases for a stream v. a single result code that can't be better handled inside the root workflow. Note that we update the Tic Tac Toe sample to take advantage. We also (nearly) make it's back button work properly on the initial screen, but that is blocked by #466. Closes #430.
rjrjr
force-pushed
the
ray/livedata-attempt-deux-430
branch
from
5b4cc94
to
74707b2
Compare
|
Forgot to run |
zach-klippenstein
approved these changes
Jul 16, 2019
|
I'll merge this as soon as I cut 0.18.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android's configuration changes make it very difficult to craft an API that
can catch all output values and also avoid double-processing of them, and each
such API we've come up with is very confusing. The cognitive cost outweighs
the benefit of allowing the Activity or Fragment to consume a stream of
outputs — if that's even a benefit! So far we have no use cases for a stream
v. a single result code that can't be better handled inside the root workflow.
Note that we update the Tic Tac Toe sample to take advantage. We also
(nearly) make it's back button work properly on the initial screen, but
that is blocked by #466.
Closes #430.