Fix WorkflowPool to work with ConflatedBroadcastChannel. #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, the renderings stream came from a regular `Channel`, and the replay/caching happened downstream. In the legacy integration code, this meant that when a V2 workflow emitted an output and got cancelled, the pool would immediately see the renderings channel was closed on the next `onWorkflowUpdate` and emit `Finished`. Now that it's backed by a `ConflatedBroadcastChannel`, it will always emit the last-emitted value on subscription before sending the close signal. This means the pool will always see the last state, and emit `Running`, which means the v2 workflow just gets restarted on the next iteration. Fixed by explicitly checking the `isActive` flag on the workflow's job before emitting `Running`.
zach-klippenstein
force-pushed
the
zachklipp/fix-workflowpool
branch
from
159d0a1
to
01d7ad8
Compare
|
Note this is merging into the release branch for 0.18.0. |
rjrjr
approved these changes
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the renderings stream came from a regular
Channel, and the replay/cachinghappened downstream. In the legacy integration code, this meant that when a V2 workflow emitted
an output and got cancelled, the pool would immediately see the renderings channel was closed on the next
onWorkflowUpdateand emitFinished. Now that it's backed by aConflatedBroadcastChannel, it willalways emit the last-emitted value on subscription before sending the close signal. This means the
pool will always see the last state, and emit
Running, which means the v2 workflow just gets restartedon the next iteration. Fixed by explicitly checking the
isActiveflag on the workflow's job beforeemitting
Running.