Never pass an empty snapshot to initialState. #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zach-klippenstein
force-pushed
the
zachklipp/dont-restore-empty-snapshots
branch
3 times, most recently
from
d802126
to
bf3bec1
Compare
zach-klippenstein
changed the title
rjrjr
approved these changes
Sep 19, 2019
kotlin/workflow-core/src/main/java/com/squareup/workflow/StatefulWorkflow.kt
Outdated
Show resolved
Hide resolved
… ByteString directly instead. Saves a few pointless allocations.
zach-klippenstein
force-pushed
the
zachklipp/dont-restore-empty-snapshots
branch
from
bf3bec1
to
3d8fe6d
Compare
zach-klippenstein
force-pushed
the
zachklipp/dont-restore-empty-snapshots
branch
from
3d8fe6d
to
615ce89
Compare
zach-klippenstein
deleted the
zachklipp/dont-restore-empty-snapshots
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two commits, I'd recommend reviewing individually.
Fixes #506