Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make RxWorker and Flowable.asWorker use Publisher instead of Flowable. #654

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Make RxWorker and Flowable.asWorker use Publisher instead of Flowable. #654

merged 1 commit into from
Oct 9, 2019

Conversation

zach-klippenstein
Copy link
Collaborator

Publisher is the non-rx-specific interface from the reactive-streams library
that Flowable implements, and that all the Flow extensions for Flowable
are actually defined on.

@zach-klippenstein
Make RxWorker and Flowable.asWorker use Publisher instead of Flowable.
4e4dc33 
`Publisher` is the non-rx-specific interface from the `reactive-streams` library
that `Flowable` implements, and that all the `Flow` extensions for `Flowable`
are actually defined on.
@zach-klippenstein zach-klippenstein added the enhancement New feature or request label Oct 9, 2019
@zach-klippenstein zach-klippenstein added this to In progress in Workflow (Kotlin) via automation Oct 9, 2019
@zach-klippenstein
Copy link
Collaborator Author

Technically, to be more pure, we "should" have a workflow-reactivestreams module or something that does this, and depend on it from the rx module. This is what kotlinx.coroutines does. But that feels like overkill for now since (afaik) nobody's using this with reactive streams without Rx, and it will be easy to extract if the need arises.

@zach-klippenstein zach-klippenstein moved this from In progress to Needs review in Workflow (Kotlin) Oct 9, 2019
@zach-klippenstein zach-klippenstein merged commit 7d55861 into master Oct 9, 2019
Workflow (Kotlin) automation moved this from Needs review to Done Oct 9, 2019
@zach-klippenstein zach-klippenstein deleted the zachklipp/generify-rxworker branch October 9, 2019 01:17
@zach-klippenstein zach-klippenstein added the kotlin Affects the Kotlin library. label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjrjr rjrjr rjrjr approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request kotlin Affects the Kotlin library.
Projects
No open projects
Workflow (Kotlin)
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zach-klippenstein @rjrjr