Throw workflow exceptions from test/testFromStart instead of leaking to uncaught exception handler. #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zach-klippenstein
force-pushed
the
zachklipp/fix-workflowtester-failure
branch
4 times, most recently
from
40156ff
to
4a76ade
Compare
rjrjr
approved these changes
Oct 18, 2019
...al-testing-utils/src/main/java/com/squareup/workflow/internal/util/UncaughtExceptionGuard.kt
Outdated
Show resolved
Hide resolved
...al-testing-utils/src/main/java/com/squareup/workflow/internal/util/UncaughtExceptionGuard.kt
Show resolved
Hide resolved
| * ## Usage | ||
| * | ||
| * 1. Register an uncaught exception handler to report uncaught exceptions with [reportUncaught]. | ||
| * 2. Run your code with [runRethrowingUncaught]. Any exceptions passed to [reportUncaught] will be |
There was a problem hiding this comment.
No discussion of rethrowingUncaughtExceptions(), so I come away unclear when I should use that and when I should use these methods directly.
There was a problem hiding this comment.
Added a note saying when to use it.
...esting-utils/src/test/java/com/squareup/workflow/internal/util/UncaughtExceptionGuardTest.kt
Outdated
Show resolved
Hide resolved
…to uncaught exception handler. Simplifies testing API by removing `awaitFailure()` – this method is now redundant since any failures are thrown from the `test`/`testFromStart` function directly. This is simpler to use since any exceptions from the workflow or runtime are now just thrown normally and will always cause tests to fail, and it doesn't require any additional API to test expected failures. Fixe #635.
zach-klippenstein
force-pushed
the
zachklipp/fix-workflowtester-failure
branch
from
4a76ade
to
df316bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies testing API by removing
awaitFailure()– this method is now redundant since anyfailures are thrown from the
test/testFromStartfunction directly. This is simpler to use sinceany exceptions from the workflow or runtime are now just thrown normally and will always cause
tests to fail, and it doesn't require any additional API to test expected failures.
Fixe #635.