Soft-deprecate ViewRegistry #816
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Would love some input on this, however I'm out of town until Dec 19th, I will be responding to feedback then. |
dhavalshreyas
changed the title
AquaGeek
reviewed
Dec 11, 2019
| @@ -25,6 +25,8 @@ import ReactiveSwift | |||
| /// In order for the registry to handle a given screen type, a view factory | |||
| /// must first be registered using `register(screenType:factory:)`, where the | |||
| /// factory is a simple closure that is responsible for instantiating a view. | |||
| /// | |||
| /// Deprecated: Return the appropriate `ViewControllerDescription` from `Screen` instead | |||
| public struct ViewRegistry { | |||
There was a problem hiding this comment.
Should this be annotated as deprecated instead of commented as deprecated?
There was a problem hiding this comment.
This triggers tons of warnings. Especially on all the Screen initializers. I decided to just use a comment here, and use the annotations for the register call.
| @@ -35,7 +35,7 @@ open class ScreenViewController<ScreenType: Screen>: UIViewController { | |||
| return ScreenType.self | |||
| } | |||
|
|
|||
| public required init(screen: ScreenType, viewRegistry: ViewRegistry) { | |||
| public required init(screen: ScreenType, viewRegistry: ViewRegistry = ViewRegistry()) { | |||
zach-klippenstein
approved these changes
Dec 11, 2019
Signed-off-by: Dhaval Shreyas <dhaval@squareup.com>
dhavalshreyas
force-pushed
the
dhaval/softDepVR
branch
from
94bc244
to
89138ac
Compare
|
Superseded by #974 |
|
This change landed here: #974 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a path for
ViewRegistrymigration without any breaking API changes.Individual
Screens can move from usingregister(screenViewControllerType:)to providing aviewControllerDescription.Initializers for both
ScreenViewControllerandContainerViewControllerhave default values forViewRegistry.This is an awkward intermediate step since we're not gaining any compile-time safety here and are introducing some dangerous side-effects like:
ViewControllerDescriptiondescribedViewControllercannot build a newViewControllerusing theViewRegistry, since it will not have the correctViewRegistryon init.ViewControllerDescriptioncan only return implementations ofScreenViewController, if not, we'll see a run-time error.This is the Migration strategy 1 as described in #815