Convert ViewRegistry to an interface. #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kotlin/workflow-ui-android/src/main/java/com/squareup/workflow/ui/ContainerHints.kt
Outdated
Show resolved
Hide resolved
zach-klippenstein
force-pushed
the
zachklipp/viewregistry-interface
branch
from
6c59523
to
6f4635f
Compare
Comment on lines
+28
to
+35
| internal val defaultViewBindings = ViewRegistry( | ||
| NamedBinding, | ||
| BackStackContainer, | ||
| ModalContainer.forAlertContainerScreen() | ||
| ) |
There was a problem hiding this comment.
These are wired up in WorkflowLayout instead of being hard-coded into any particular ViewRegistry class.
zach-klippenstein
force-pushed
the
zachklipp/viewregistry-interface
branch
from
6f4635f
to
5ba0c87
Compare
zach-klippenstein
changed the title
|
This is ready for review! |
zach-klippenstein
force-pushed
the
zachklipp/viewregistry-interface
branch
from
5ba0c87
to
8059400
Compare
rjrjr
approved these changes
Dec 18, 2019
kotlin/workflow-ui-android/src/main/java/com/squareup/workflow/ui/CompositeViewRegistry.kt
Outdated
Show resolved
Hide resolved
zach-klippenstein
force-pushed
the
zachklipp/viewregistry-interface
branch
from
5110977
to
88f7424
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #831.