Drastically simplifies ModalViewContainer. #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrjr
force-pushed
the
ray/better-modals
branch
from
12f006b
to
8d3539f
Compare
rjrjr
changed the title
rjrjr
force-pushed
the
ray/better-modals
branch
2 times, most recently
from
38e5e5a
to
5e2de83
Compare
zach-klippenstein
approved these changes
Jan 25, 2020
rjrjr
force-pushed
the
ray/better-modals
branch
from
5e2de83
to
41b6f45
Compare
|
Update fixes stale kdoc on |
Trying to protect container authors from calling the `Dialog` constructor was foolish. Didn't actually simplify anything, and made it very difficult to manage window size. Panel sample behavior around soft keyboard is a lot better now.
rjrjr
force-pushed
the
ray/better-modals
branch
from
41b6f45
to
4ff8867
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to protect container authors from calling the
Dialogconstructor was foolish. Didn't actually simplify anything,
and made it very difficult to manage window size.
Panel sample behavior around soft keyboard is a lot better now.