Pass acceptOutput function to WorkflowNode constructor instead of every tick pass. #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry tick pass. This doesn't change any behavior, it is just more efficient: there's no need to define the function at the tick pass, so this is not only more efficient but also just easier to read, since there are fewer moving parts. This is also required for #910.
zach-klippenstein
force-pushed
the
zachklipp/extract-update-handler
branch
from
00011b8
to
4f55451
Compare
zach-klippenstein
changed the title
zach-klippenstein
added a commit
that referenced
this pull request
Jan 25, 2020
Based on #916. Implements and closes #910.
dhavalshreyas
approved these changes
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't change any behavior, it is just more efficient: there's no need to
define the function at the tick pass, so this is not only more efficient but also
just easier to read, since there are fewer moving parts.
This is also required for square/workflow-kotlin#762.