Make WorkflowTester tests use the main context as the worker context. #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zach-klippenstein
force-pushed
the
zachklipp/better-worker-fix
branch
from
ffa2556
to
94482a2
Compare
zach-klippenstein
force-pushed
the
zachklipp/better-worker-fix
branch
2 times, most recently
from
befaf36
to
dbe6aa9
Compare
This is an enhancement to #940 that gives more reasonable behavior. The context parameter to the test methods are primarily used to pass in test dispatchers, and those dispatchers often really only need to be used for workers. Since I don't know of a use case for specifying context separately just for workers, this also removes the `WorkflowTestParams.workerContext` property.
zach-klippenstein
force-pushed
the
zachklipp/better-worker-fix
branch
from
dbe6aa9
to
b64a0b7
Compare
Armaxis
approved these changes
Feb 6, 2020
tehras
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an enhancement to #940 that gives more reasonable behavior. The context
parameter to the test methods are primarily used to pass in test dispatchers, and
those dispatchers often really only need to be used for workers.
Since I don't know of a use case for specifying context separately just for workers,
this also removes the
WorkflowTestParams.workerContextproperty.