Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression evaluation metrics #116

Merged
merged 18 commits into from
Feb 3, 2023
Merged

Conversation

NickNtamp
Copy link
Contributor

@NickNtamp NickNtamp commented Jan 25, 2023

Additions:

  • Regression evaluation metrics along with unit tests where added. The 3 more common metrics are there (r2, mse, mae)
  • Regression model based on lgbm regressor was added. The r2 score is pretty low there but there are not many things we can do!
  • LIME for regression was added
  • Documentation was added along with the missing part for drifting metrics

Also closes: https://github.com/squaredev-io/administration/issues/422

@NickNtamp NickNtamp linked an issue Jan 25, 2023 that may be closed by this pull request
@NickNtamp NickNtamp changed the title Add regression evaluation metrics [WIP] Add regression evaluation metrics Jan 25, 2023
@NickNtamp NickNtamp marked this pull request as draft January 25, 2023 09:58
@NickNtamp NickNtamp marked this pull request as ready for review January 25, 2023 12:59
@NickNtamp NickNtamp changed the title [WIP] Add regression evaluation metrics Add regression evaluation metrics Jan 25, 2023
@NickNtamp NickNtamp requested a review from sinnec January 25, 2023 12:59
@sinnec sinnec marked this pull request as draft January 26, 2023 11:19
@sinnec sinnec requested a review from momegas January 27, 2023 15:43
@sinnec
Copy link
Contributor

sinnec commented Jan 27, 2023

I'm done. I think @momegas or @stavrostheocharis should review this to judge on the whole picture!

@NickNtamp NickNtamp requested review from stavrostheocharis and removed request for sinnec January 28, 2023 16:19
@sinnec sinnec marked this pull request as ready for review January 31, 2023 10:23
@sinnec sinnec marked this pull request as draft January 31, 2023 10:27
@sinnec sinnec marked this pull request as ready for review January 31, 2023 10:33
Copy link
Member

@momegas momegas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this is great. I have some questions but most likely it will open to bigger discussions so lets not tackle them now. We can come back later.

Can we also have some notebook examples for regression models?

docs/mkdocs/docs/metric-definitions.md Show resolved Hide resolved
docs/mkdocs/docs/sdk-docs.md Show resolved Hide resolved
docs/mkdocs/docs/tutorial/metrics.md Outdated Show resolved Hide resolved
docs/mkdocs/docs/tutorial/metrics.md Outdated Show resolved Hide resolved
whitebox/analytics/models/pipelines.py Show resolved Hide resolved
whitebox/schemas/modelMonitor.py Show resolved Hide resolved
@NickNtamp
Copy link
Contributor Author

Overall, this is great. I have some questions but most likely it will open to bigger discussions so lets not tackle them now. We can come back later.

Can we also have some notebook examples for regression models?

I am planning to have some but not under this ticket. I will add them in the notebooks roadmap ticket.

@momegas momegas merged commit 9611a27 into main Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Roadmap] Add regression models
4 participants