Dataset endpoints #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Datasets - Dataset rows
momegas
approved these changes
Nov 4, 2022
src/tests/v1/test_dataset_rows.py
Outdated
Comment on lines
7
to
19
| @pytest.mark.order(test_order_map["dataset_rows"]["create"]) | ||
| def test_dataset_row_create_many(client): | ||
| response = client.post( | ||
| "/v1/datasets/rows", | ||
| json=list(map(lambda x: {**x, "dataset_id": state.dataset["id"]}, dataset_rows_create_payload)) | ||
| ) | ||
| assert response.status_code == status.HTTP_201_CREATED | ||
|
|
||
|
|
||
| @pytest.mark.order(test_order_map["dataset_rows"]["get_dataset's_all"]) | ||
| def test_dataset_row_get_datasets_all(client): | ||
| response = client.get(f"/v1/datasets/{state.dataset['id']}/rows") | ||
| assert response.status_code == status.HTTP_200_OK |
There was a problem hiding this comment.
It would be nice if we can also have tests the non-happy paths
src/tests/v1/test_datasets.py
Outdated
Comment on lines
7
to
21
| @pytest.mark.order(test_order_map["datasets"]["create"]) | ||
| def test_dataset_create(client): | ||
| response = client.post( | ||
| "/v1/datasets/metadata", | ||
| json={**dataset_create_payload, "user_id": state.user["id"]}, | ||
| ) | ||
|
|
||
| state.dataset = response.json() | ||
| assert response.status_code == status.HTTP_201_CREATED | ||
|
|
||
|
|
||
| @pytest.mark.order(test_order_map["datasets"]["get"]) | ||
| def test_dataset_get(client): | ||
| response = client.get(f"/v1/datasets/{state.dataset['id']}") | ||
| assert response.status_code == status.HTTP_200_OK |
|
@momegas Please re-review. Had some problem with creating 422 in the endpoints and only got 400... We'll write fail case tests for all endpoints soon! |
sinnec
commented
Nov 4, 2022
| return new_dataset | ||
| else: | ||
| return errors.not_found(f"User with id: {body.__dict__['user_id']} not found") | ||
|
|
There was a problem hiding this comment.
Is there something better than dict to use?
There was a problem hiding this comment.
Oh, this is a pydantic datastructure right. There is a .dict(). Have a look here
momegas
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Endpoints for:
closes: #13